Welcome to ask.fedora! At first, this looked puzzling, but then I read the man page for firewall-cmd (man firewall-cmd) and found this:
The permanent option --permanent can be used to set options

If you haven't done so already, try restarting the firewald daemon.